Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for multi network #283

Merged
merged 3 commits into from
Nov 24, 2021
Merged

add support for multi network #283

merged 3 commits into from
Nov 24, 2021

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Nov 17, 2021

No description provided.

@l1b0k l1b0k self-assigned this Nov 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2021 •
edited
Loading

Codecov Report

Merging #283 (09d4772) into main (6136030) will decrease coverage by 0.30%.
The diff coverage is 0.41%.

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #283      +/-   ##
========================================
- Coverage   4.81%   4.50%   -0.31%     
========================================
  Files         94      98       +4     
  Lines       9293    9432     +139     
========================================
- Hits         447     425      -22     
- Misses      8812    8974     +162     
+ Partials      34      33       -1
Flag Coverage Δ
unittests 4.50% <0.41%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/terway-controlplane/terway-controlplane.go 3.27% <0.00%> (-28.19%) ⬇️
daemon/daemon.go 3.51% <0.00%> (-0.01%) ⬇️
daemon/k8s.go 0.00% <0.00%> (ø)
examples/maxpods/maxpods.go 19.35% <0.00%> (ø)
pkg/aliyun/aliyun_client_mgr.go 0.00% <0.00%> (ø)
pkg/aliyun/credential/sts.go 0.00% <0.00%> (ø)
pkg/aliyun/ecs.go 0.00% <0.00%> (ø)
....alibabacloud.com/v1beta1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
pkg/cert/webhook.go 0.00% <0.00%> (ø)
pkg/controller/common/types.go 0.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6136030...09d4772. Read the comment docs.

@l1b0k l1b0k changed the title support multi network add support for multi network Nov 17, 2021
@l1b0k l1b0k requested a review from BSWANG November 17, 2021 12:53
@l1b0k l1b0k merged commit 94c2a85 into AliyunContainerService:main Nov 24, 2021
@l1b0k l1b0k deleted the multi_nic branch November 24, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BSWANG BSWANG Awaiting requested review from BSWANG

Assignees

@l1b0k l1b0k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l1b0k @codecov-commenter